-
Notifications
You must be signed in to change notification settings - Fork 5
Develop a validation strategy #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lidation-strategy
…ding to class structure
# Conflicts: # docs/javadoc/edu/ie3/datamodel/utils/ValidationUtils.html
Codecov Report
@@ Coverage Diff @@
## dev #197 +/- ##
============================================
+ Coverage 77.98% 78.55% +0.57%
- Complexity 1951 2075 +124
============================================
Files 249 254 +5
Lines 7936 8260 +324
Branches 749 821 +72
============================================
+ Hits 6189 6489 +300
- Misses 1321 1359 +38
+ Partials 426 412 -14 Continue to review full report at Codecov.
|
!test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! You did a great job! Although I only have minor remarks, the sum up to a pretty large sum... :-(
Additionally, there are no tests for GridContainerValidationUtils
. Do you intend to add them or is this part of a future issue?
src/test/groovy/edu/ie3/datamodel/utils/validation/ConnectorValidationUtilsTest.groovy
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/utils/validation/ConnectorValidationUtilsTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/utils/validation/ConnectorValidationUtilsTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/utils/validation/NodeValidationUtilsTest.groovy
Outdated
Show resolved
Hide resolved
!test |
…ation-strategy # Conflicts: # CHANGELOG.md # Jenkinsfile # src/main/java/edu/ie3/datamodel/models/input/container/InputContainer.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason, why you haven't have tests for GridContainerValidationUtils
? I think this is the only issue, why the quality gate is breaking atm.
closes #81