Skip to content

Develop a validation strategy #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 123 commits into from
Apr 1, 2021
Merged

Conversation

NGL04
Copy link
Contributor

@NGL04 NGL04 commented Sep 2, 2020

closes #81

@NGL04 NGL04 requested review from johanneshiry and ckittl September 2, 2020 07:44
@NGL04 NGL04 self-assigned this Sep 2, 2020
@johanneshiry johanneshiry changed the base branch from master to dev September 11, 2020 15:17
@NGL04 NGL04 marked this pull request as ready for review January 21, 2021 10:21
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #197 (709f564) into dev (eed20af) will increase coverage by 0.57%.
The diff coverage is n/a.

❗ Current head 709f564 differs from pull request most recent head bf1c228. Consider uploading reports for the commit bf1c228 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #197      +/-   ##
============================================
+ Coverage     77.98%   78.55%   +0.57%     
- Complexity     1951     2075     +124     
============================================
  Files           249      254       +5     
  Lines          7936     8260     +324     
  Branches        749      821      +72     
============================================
+ Hits           6189     6489     +300     
- Misses         1321     1359      +38     
+ Partials        426      412      -14     
Impacted Files Coverage Δ Complexity Δ
.../edu/ie3/datamodel/exceptions/SourceException.java 33.33% <0.00%> (-33.34%) 1.00% <0.00%> (-1.00%)
...u/ie3/datamodel/models/result/system/HpResult.java 68.42% <0.00%> (-31.58%) 4.00% <0.00%> (+1.00%) ⬇️
.../ie3/datamodel/io/csv/FileNameMetaInformation.java 40.00% <0.00%> (-20.00%) 2.00% <0.00%> (-1.00%)
.../edu/ie3/datamodel/models/value/HeatAndPValue.java 36.36% <0.00%> (-18.19%) 3.00% <0.00%> (-1.00%)
...del/models/input/container/JointGridContainer.java 60.00% <0.00%> (-16.20%) 4.00% <0.00%> (-3.00%)
...imeseries/IndividualTimeSeriesMetaInformation.java 33.33% <0.00%> (-8.34%) 2.00% <0.00%> (-1.00%)
.../edu/ie3/datamodel/io/connectors/SqlConnector.java 62.50% <0.00%> (-6.25%) 8.00% <0.00%> (-4.00%)
...atamodel/models/input/container/GridContainer.java 70.96% <0.00%> (-0.91%) 10.00% <0.00%> (ø%)
...edu/ie3/datamodel/io/source/csv/CsvDataSource.java 90.05% <0.00%> (-0.06%) 53.00% <0.00%> (-1.00%)
...e3/datamodel/io/csv/DefaultDirectoryHierarchy.java 93.85% <0.00%> (-0.06%) 25.00% <0.00%> (ø%)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68447b2...bf1c228. Read the comment docs.

@ckittl
Copy link
Member

ckittl commented Feb 3, 2021

!test

Copy link
Member

@ckittl ckittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! You did a great job! Although I only have minor remarks, the sum up to a pretty large sum... :-(

Additionally, there are no tests for GridContainerValidationUtils. Do you intend to add them or is this part of a future issue?

@johanneshiry
Copy link
Member

!test

@ckittl ckittl added this to the Version 2.0 milestone Mar 31, 2021
Copy link
Member

@ckittl ckittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason, why you haven't have tests for GridContainerValidationUtils? I think this is the only issue, why the quality gate is breaking atm.

@ckittl ckittl merged commit a760155 into dev Apr 1, 2021
@ckittl ckittl deleted the ns/#81-develop-a-validation-strategy branch April 1, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop a validation strategy
3 participants