Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply clippy fixes #238

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Apply clippy fixes #238

wants to merge 3 commits into from

Commits on Jan 30, 2024

  1. apply automatic clippy fixes

    @tim-hoffman
    tim-hoffman committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    ff7bf5d View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Apply remaining manual clippy suggestions 

    Some were ignored with "allow" annotations to avoid changing public interfaces
    @tim-hoffman
    tim-hoffman committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    0e539bb View commit details
    Browse the repository at this point in the history

  2. Remove some unnecessary Box/Option clones 

    Box::clone followed by immediate dereference is replaced with first referencing the value out of the box and cloning only that value to avoid cloning the Box itself.
    @tim-hoffman
    tim-hoffman committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3c669ba View commit details
    Browse the repository at this point in the history