Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply clippy fixes #238

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Apply clippy fixes #238

wants to merge 3 commits into from

Conversation

tim-hoffman
Copy link
Contributor

  • Applied fixes suggested by "cargo clippy"
  • A few of the suggestions were ignored by adding "allow" annotations to avoid changing public interfaces. These can be revisited in the future to assess the impact of minor changes to public interfaces.
  • Box::clone followed by immediate de-reference is changed to first reference the value out of the box and clone only that value to avoid cloning the Box itself.
  • Also a few other minor formatting changes and code simplifications.

@tim-hoffman
apply automatic clippy fixes
ff7bf5d
@tim-hoffman
Apply remaining manual clippy suggestions
0e539bb 
Some were ignored with "allow" annotations to avoid changing public interfaces
@tim-hoffman
Remove some unnecessary Box/Option clones
3c669ba 
Box::clone followed by immediate dereference is replaced with first referencing the value out of the box and cloning only that value to avoid cloning the Box itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clararod9 clararod9 Awaiting requested review from clararod9

@alrubio alrubio Awaiting requested review from alrubio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tim-hoffman