-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new page Calibration type 10 details #354
Add new page Calibration type 10 details #354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MSECode
Thanks for the new page!
Some inline comments to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, rename the file using underscores to comply to the naming convention of the other files in the same directory.
docs/robot_calibration_types/amo-encoder-joint-calibration-10-details.md
Outdated
Show resolved
Hide resolved
docs/robot_calibration_types/amo-encoder-joint-calibration-10-details.md
Outdated
Show resolved
Hide resolved
docs/robot_calibration_types/amo-encoder-joint-calibration-10-details.md
Outdated
Show resolved
Hide resolved
docs/robot_calibration_types/amo-encoder-joint-calibration-10-details.md
Outdated
Show resolved
Hide resolved
docs/robot_calibration_types/amo-encoder-joint-calibration-10-details.md
Outdated
Show resolved
Hide resolved
docs/robot_calibration_types/amo-encoder-joint-calibration-10-details.md
Outdated
Show resolved
Hide resolved
d066ce2
to
04e8e85
Compare
…ration Update calibration type 10 doc Add state machine for showing pipeline of hard-stop calibration when using AMO encoder at joint plus qudrature encoder at motor Add some line detailinhg the steps of the state machine
04e8e85
to
28026d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MSECode!
Just a couple of amendments I'll commit myself straight away.
docs/robot_calibration_types/amo_encoder_joint_calibration_10_details.md
Outdated
Show resolved
Hide resolved
docs/robot_calibration_types/amo_encoder_joint_calibration_10_details.md
Outdated
Show resolved
Hide resolved
Thanks |
Update calibration type 10 doc
Add state machine for showing pipeline of hard-stop calibration when using AMO encoder at joint plus quadrature encoder at motor Add some line detailing the steps of the state machine
This PR aims at adding new details to the calibration type 10, which is the calibration of a joint to a defined hard-stop position, for joints provided with an AMO encoder at the joint and a quadrature encoder at the motor.
Basically a state machine diagram showing the calibration pipeline is shown and described so that now it is easier for somebody to know what is a joint that implements that calibration is doing.