Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new page Calibration type 10 details #354

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

MSECode
Copy link
Member

@MSECode MSECode commented Jun 20, 2024

Update calibration type 10 doc
Add state machine for showing pipeline of hard-stop calibration when using AMO encoder at joint plus quadrature encoder at motor Add some line detailing the steps of the state machine

This PR aims at adding new details to the calibration type 10, which is the calibration of a joint to a defined hard-stop position, for joints provided with an AMO encoder at the joint and a quadrature encoder at the motor.
Basically a state machine diagram showing the calibration pipeline is shown and described so that now it is easier for somebody to know what is a joint that implements that calibration is doing.

@MSECode MSECode requested a review from pattacini as a code owner June 20, 2024 13:35
@MSECode MSECode self-assigned this Jun 20, 2024
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MSECode

Thanks for the new page!
Some inline comments to address.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rename the file using underscores to comply to the naming convention of the other files in the same directory.

mkdocs.yml Outdated Show resolved Hide resolved
docs/robot_calibration_types/standard_calibration_types.md Outdated Show resolved Hide resolved
…ration

Update calibration type 10 doc
Add state machine for showing pipeline of hard-stop calibration
when using AMO encoder at joint plus qudrature encoder at motor
Add some line detailinhg the steps of the state machine
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MSECode!
Just a couple of amendments I'll commit myself straight away.

@pattacini pattacini merged commit b400997 into icub-tech-iit:master Jun 21, 2024
1 check passed
@MSECode MSECode deleted the feature/absEncoderDoc branch June 21, 2024 08:46
@MSECode
Copy link
Member Author

MSECode commented Jun 21, 2024

amendments

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants