Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get joint information from element tree #66

Merged
merged 11 commits into from
Dec 4, 2023
Merged

Get joint information from element tree #66

merged 11 commits into from
Dec 4, 2023

Conversation

mfussi66
Copy link
Member

@mfussi66 mfussi66 commented Dec 1, 2023

This PR updates the plugin by simplifying the retrieval of joint information:

  • The element tree is used to get the constraint type (therefore joint type)
  • From each part we get the parent link and the constraint axis in case of Pin, and coordinate system in case of Fixed

@mfussi66 mfussi66 changed the title first example function using elementtree Get joint information from element tree Dec 1, 2023
Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe we can think of moving some functions that are not strictly related to the elementTree in Utils.h but this could be done in future refinement.

I would edit the README removing the assumptions that now we overcome with this new implementation!

@Nicogene
Copy link
Member

Nicogene commented Dec 4, 2023

Today I tested these changes on my laptop and:

  • It compiles
  • It works
  • After exporting the ergoCub urdf the diff in ergocub-software is null, this means we managed to make it more robust keeping the functionalities.

Merging!

@Nicogene Nicogene merged commit 1b53379 into master Dec 4, 2023
@Nicogene Nicogene deleted the elementtree branch December 4, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CREO2URDF – Retrieve the joint info from the mechanism
2 participants