[GHA][CI] Fixed integration tests callable to use the same PHP version #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ezrobot
requested review from
Steveb-p,
ViniTou,
adamwojs,
barw4,
ciastektk,
mikadamczyk and
wiewiurdp
and removed request for
a team
konradoboza
approved these changes
Jun 24, 2025
barw4
approved these changes
Jun 24, 2025
This was referenced Jun 24, 2025
This was referenced Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
We bumped the default PHP image to use 8.3 version during releases ibexa/ci-scripts#91. However, there's a GHA that installs PHP 7.4 dependencies, but then tries to run the whole instance using that default 8.3.
Attempting here to fix it so it relies uniformly on the same PHP version.
Question: should we also run these integration tests on the other PHP versions? Not going for this due to resource consumption, but maybe it's worth to. Current change makes it easy to add in the future also.
Side note: additionally I've fixed outstanding issue in Xml input handler, detected by PHPStan and failing on CI. Yeah, I know you've seen this before in the other PRs. I guess it depends on which one gets merged first.