IBX-9328: Implemented dedicated endpoint that handles user group creation under root #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
ciastektk,
mikadamczyk and
wiewiurdp
and removed request for
a team
barw4
changed the title
adamwojs
approved these changes
Jun 17, 2025
composer.json
Outdated
| "ext-simplexml": "*", | ||
| "ext-xmlwriter": "*", | ||
| "ibexa/core": "~4.6.0@dev", | ||
| "ibexa/core": "dev-ibx-9328-users-root-path as 4.6.0@dev", |
Member
There was a problem hiding this comment.
Friendly reminder: drop temporary commit before the merge
| path: /user/groups/subgroups | ||
| defaults: | ||
| _controller: Ibexa\Rest\Server\Controller\User:createUserGroup | ||
| _controller: Ibexa\Rest\Server\Controller\User:createRootUserGroup |
Member
There was a problem hiding this comment.
Suggested change
| _controller: Ibexa\Rest\Server\Controller\User:createRootUserGroup | |
| _controller: Ibexa\Rest\Server\Controller\User::createRootUserGroup |
Syntax with single : is deprecated on Symfony 5.4 and removed in later versions.
alongosz
approved these changes
Jun 17, 2025
konradoboza
approved these changes
Jun 18, 2025
| { | ||
| $text = $this->addTestSuffix(__FUNCTION__); | ||
| $xml = <<< XML | ||
| <?xml version="1.0" encoding="UTF-8"?> |
Contributor
There was a problem hiding this comment.
Indentation works for HEREDOC since a long time.
Contributor
Author
There was a problem hiding this comment.
It's highlighted for XML as an issue in IDE, besides we don't have any indentation anywhere for XMLs in this package.
alongosz
reviewed
Jun 24, 2025
barw4
force-pushed
the
ibx-9328-create-top-level-user-group
branch
from
13dc68b to
a81e155
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
ibexa/core#594
Description:
This PR creates a new REST action inside the User controller that creates a user group under the root users group:
createRootUserGroupbased onusers_group_root_subtree_pathconfig parameter.For QA:
Documentation: