IBX-6554: Prevent Twig errors when location is not defined in Location View #1517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adamwojs
changed the title
adamwojs
approved these changes
May 24, 2025
Member
|
@tbialcz Rebase is needed here |
dew326
approved these changes
May 26, 2025
… not defined # Conflicts: # src/bundle/Resources/views/themes/admin/content/location_view.html.twig
…om/ibexa/admin-ui into IBX-6554-location-view-null-checks # Conflicts: # src/bundle/Resources/views/themes/admin/content/location_view.html.twig
Steveb-p
reviewed
Jun 16, 2025
src/bundle/Resources/views/themes/admin/content/location_view.html.twig
Outdated
Show resolved
Hide resolved
tbialcz
force-pushed
the
IBX-6554-location-view-null-checks
branch
2 times, most recently
from
26f260f to
2e515a3
Compare
…ing location in controller
tbialcz
force-pushed
the
IBX-6554-location-view-null-checks
branch
from
2e515a3 to
0f595d0
Compare
alongosz
reviewed
Jun 18, 2025
…er consistency and null safety
tbialcz
force-pushed
the
IBX-6554-location-view-null-checks
branch
from
22da30e to
4192309
Compare
konradoboza
approved these changes
Jun 25, 2025
tbialcz
force-pushed
the
IBX-6554-location-view-null-checks
branch
2 times, most recently
from
7e45798 to
84a47dd
Compare
…d clarity and null safety
tbialcz
force-pushed
the
IBX-6554-location-view-null-checks
branch
from
84a47dd to
451b04a
Compare
tomaszszopinski
approved these changes
Jun 25, 2025
Contributor
tomaszszopinski
left a comment
tomaszszopinski
left a comment
There was a problem hiding this comment.
QA approved on Ibexa DXP 4.6 commerce.
alongosz
reviewed
Jun 25, 2025
tbialcz
force-pushed
the
IBX-6554-location-view-null-checks
branch
from
a44e34a to
4bf8f3f
Compare
tbialcz
force-pushed
the
IBX-6554-location-view-null-checks
branch
from
4bf8f3f to
d2aef9b
Compare
tbialcz
force-pushed
the
IBX-6554-location-view-null-checks
branch
from
d2aef9b to
21cf2e6
Compare
|
alongosz
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR updates the location_view.html.twig template to prevent runtime errors when location is not passed (e.g. when viewing deleted/trashed assets or content without an accessible location).