IBX-6554: Enhanced null safety and refactored location ID checks in LocationVoter

Author: tbialcz

phpstan-baseline.neon

@@ -11496,12 +11496,6 @@ parameters:
 			count: 1
 			path: src/lib/Menu/UserSetting/UserSettingUpdateRightSidebarBuilder.php
 
-		-
-			message: '#^Cannot access property \$attributes on Symfony\\Component\\HttpFoundation\\Request\|null\.$#'
-			identifier: property.nonObject
-			count: 1
-			path: src/lib/Menu/Voter/LocationVoter.php
-
 		-
 			message: '#^Call to an undefined method Symfony\\Component\\HttpFoundation\\Session\\SessionInterface\:\:getFlashBag\(\)\.$#'
 			identifier: method.notFound

src/lib/Menu/Voter/LocationVoter.php

@@ -9,6 +9,7 @@
 namespace Ibexa\AdminUi\Menu\Voter;
 
 use Ibexa\Core\MVC\Symfony\View\ContentView;
+use Ibexa\Core\Repository\Values\Content\Location;
 use Knp\Menu\ItemInterface;
 use Knp\Menu\Matcher\Voter\VoterInterface;
 use Symfony\Component\HttpFoundation\RequestStack;
@@ -26,20 +27,24 @@ public function __construct(RequestStack $requestStack)
 
     public function matchItem(ItemInterface $item): ?bool
     {
-        $routes = $item->getExtra('routes', []);
-
-        foreach ($routes as $route) {
-            if (isset($route['route']) && $route['route'] === self::CONTENT_VIEW_ROUTE_NAME) {
-                $request = $this->requestStack->getCurrentRequest();
-                $contentView = $request->attributes->get('view');
-                $locationId = $route['parameters']['locationId'];
-
-                if ($contentView instanceof ContentView) {
-                    $location = $contentView->getLocation();
-                    if ($location !== null && in_array($locationId, $location->path ?? [$location->id])) {
-                        return true;
-                    }
-                }
+        foreach ($item->getExtra('routes', []) as $route) {
+            $routeName = $route['route'] ?? null;
+            $locationId = isset($route['parameters']['locationId']) ? (int)$route['parameters']['locationId'] : null;
+
+            if ($routeName !== self::CONTENT_VIEW_ROUTE_NAME || $locationId === null) {
+                continue;
+            }
+
+            $request = $this->requestStack->getCurrentRequest();
+            $contentView = $request ? $request->attributes->get('view') : null;
+            $location = $contentView instanceof ContentView ? $contentView->getLocation() : null;
+
+            if (!$location instanceof Location) {
+                continue;
+            }
+
+            if (in_array($locationId, array_map('intval', $location->getPath()), true)) {
+                return true;
             }
         }