Repository navigation
Real cores enumerate real capture devices only (#739) - #755
Merged
Merged
Conversation
… pair is stub-tier (#739) createDefaultModules() carried the stub's FakeCaptureDevice into every build as the first member of the capture composite: a 'connected' DeckLink Mini Recorder 4K and an AJA Io 4K Plus that do not exist, with a 640x360 test pattern generated on every capture tick. The WinUI shell hid them with an id-prefix filter; the mac shell listed them. The fake pair is now added only under COREVIDEO_STUB. A non-stub core starts from an empty device (MediaCore dereferences captureDevice without a null check) and holds whatever real adapters construct. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The range-for walked captureDevices().asArray() on a temporary that was already destroyed, so the test read freed memory: it failed in the stub tier and passed vacuously in the real build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #739
Problem
createDefaultModules()carried the stub tier'sFakeCaptureDeviceinto every build as the first member of the capture composite:capture:decklink-1on every capture tickMapCoreOwnedCaptureDevice); the mac shell lists the core's devices unfiltered, so it showed themChange
COREVIDEO_STUB.NoCaptureDevice(MediaCoredereferencescaptureDevicewithout a null check) and holds whatever real adapters construct.createStubModules(); a new test pins the rule in both tiers.Verification
corevideo-native.exeansweredlist-capture-deviceswith 17 real devices on this machine (6 UVC, 4 displays, 7 windows) and nodecklink-1/aja-io-1.The #739 BACKLOG row is removed in the follow-up PR for #742 to avoid a conflict with #753.
🤖 Generated with Claude Code