Break up HUD elements into individual OSD elements #9199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break up hud elements as individual OSD elements to allow different layouts to show/hide those elements.
This was referenced Jul 27, 2023
Previous number was 4(hud_radar_disp max) + 1 Now it is 6 + 1.
Still depend on the crosshair, but should be clearer. Needs testing
|
I am curious to see how this would work with the hud clearing happening in the crosshair, and the drawing of the individual hud elements happening afterwards. Due to the nature of how the drawing happens (by element id), the behavior should be similar, except that osdHudDrawHoming() used to happen before clearing hud, and now will happen after. If there are side effects, we can move the individual elements back to the OSD_CROSSHAIRS case and just check if the individual elements are supposed to be displayed (like the first draft). |
mmosca
added
Testing Required
Release Notes
This lets the OSD element visibility be the only setting that controls the visibility of these elements in the HUD
I saw some strange artifacts, reverting to old style display for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks up hud elements as individual OSD elements to allow different layouts to show/hide those elements.
This needs testing, as there may be side effects due to the order elements are drawn. We still check for the crosshair to be there, are it has a call to osdHudClear
This also need mentioning in the Release notes, as osd_hud_homepoint and osd_hud_homing settings have been replaced by the equivalent OSD elements and osd_hud_radar/wp_disp no longer control INAV Radar element visibility in the HUD.