Make programming framework CLI safe #8266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the programming framework has code to change the profiles. This can result in profiles not being correctly read or written. Moving the programming framework to the end of the diff/dump completely negates this issue. Cleared up some of the hash headers while I was there.
MrD-RC
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the programming framework has code to change the control profiles. This can result in profiles not being correctly read or written, as they cannot be changed. Also, editing a specific profile in CLI can also be effected. This PR pauses all LC processing while in the CLI.
Cleared up some of the hash headers while I was there.
Example of some CLI commands. You can see LCs 35 to 41 are set to change the profile every 2nd cycle.
CLI Clipboard.txt