Separate D and CD/FF adjustments #6674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
There is a bug in this PR, trying to figure out what causes it. When the adjustment is selected the correct osd element starts blinking, but when you try to change the pitch or yaw D and FF gains, the corresponding roll gain is changed instead. |
Member
|
@avsaase shall we merge? |
Member
Author
|
Sounds good! |
DzikuVx
added
the
Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the combined adjustment functions for D (multirotor) and FF (fixed wing) into separate D and FF adjustments so that they both can be changed either via adjustments or via the OSD menu. On multirotor, FF adjustment changes the CD gain.
I changed the order of the adjustments so I created iNavFlight/inav-configurator#1187 to realign the indices.
This is a breaking change that will require manually setting up the adjustments after updating, or perhaps we could make a conversion tool like
box2permso that the CLI commands can be converted. I will make a conversion table later.