-
Notifications
You must be signed in to change notification settings - Fork 1.7k
OSD summary stats improvements #6548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSD summary stats improvements #6548
Conversation
|
Is |
|
@avsaase Does this allow DISARMED BY to now fit on the page, without being half cut off? Another tidy up suggestion. Instead of the Amps, Watts and Power unit letters being alphabet characters.
|
|
@Jetrell For me DISARMED BY still falls off the bottom off the screen (completely) when using NTSC. I think having two max g-force lines is unnecessary but I assumed they are included for a reason. If not I'd like to remove the min/max Z g-force line. Good idea about the symbols. I'll try to make that change this week. |
I think so too. The G-force stats give a wrong readout most of the time, because they also record the touch down or landing G-force. Which is not useful at all. |
|
I would also be okay with removing both lines. |
|
why not show all available rows, wait a few seconds, clear the screen, and then show the remaining rows? |

Changes:
osd_stats_min_voltage_unit = CELL, the average min cell voltage is shown instead of the total battery voltage. The default isBATTERYwhich is the current behavior.I do not fully understand all the
buffandstatValuesXstuff but I managed to throw this together. There are a couple things I'm not yet happy with:/separating it from the current voltage. I tried accounting for this usingdisplayWrite(osdDisplayPort, statValuesX + 4 + osdConfig()->main_voltage_decimals, top++, buff);but this doesn't work. Again it would be nicer to paste the strings together based on their actual length instead of some fixed number of characters.I will later add the configurator side of this PR (also for
osd_stats_energy_unit).