Create separate target for SDCARD default for MATEKF722WPX #6252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well spotted, thanks! |
|
Just wanted to open a new issue as the MSC mode does not work with the Matek provided 2.5.1 and it may be worth looking into it too. MSC mode is initiated but no drive appears. I guess this will be fixed with the separate target too and may have the same cause. |
|
No, this does not address any MSC issue, which is most likely a duplicate of #5860 for some combination of F722/MSC/Windows, with a variety of inconclusive reports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes to the MATEKF722PX
target.henabling SD card logging on MATEKF722WPX have the unfortunate side-effect of causing the configurator to freeze when the Blackbox log tab is accessed on the SDCARD variant, due the the default logging device being set to SPIFLASH.The use could remedy this by setting
set blackbox_device = SDCARDin the CLI, but many of them won't.This PR resolves this usability issue by creating a separate target. Appreciate this is sub-optimal target proliferation, but I'm not aware of any other way to resolve this.
Discussion with reporting user https://www.rcgroups.com/forums/showpost.php?p=45781093&postcount=26671 et al.