Skip to content

Conversation

giacomo892
Copy link
Collaborator

@giacomo892 giacomo892 commented Mar 4, 2019

Adding the possibility to choose between PT1 and BIQUAD lfp to filter gyro signals.

Configurator support is still missing, if we will ever need it.

@giacomo892 giacomo892 added the Feedback required The issue/PR is missing information to proceed further label Mar 4, 2019
@DzikuVx
Copy link
Member

DzikuVx commented Mar 4, 2019

It's like going back in time :)

@giacomo892 giacomo892 force-pushed the PT1_gyro_filters_giacomo892 branch from e7a11d4 to ad946f9 Compare March 4, 2019 15:46
@giacomo892
Copy link
Collaborator Author

It's like going back in time :)

Perhaps faster loop times and better builds will let us benefit from less filtering and so less delay?

Copy link
Member

@digitalentity digitalentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DzikuVx
Copy link
Member

DzikuVx commented Mar 4, 2019

I'm very much willing to test it over the weekend

@giacomo892
Copy link
Collaborator Author

@DzikuVx Thanks. Weather will not very good here.

Also I tought adding the same to the 2nd stage filter, but that doesn't seems a biquad like main LPF. Why is it different from the 1st LPF (which is actually the second in the chain LOL)?

@DzikuVx
Copy link
Member

DzikuVx commented Mar 8, 2019

@DzikuVx
Copy link
Member

DzikuVx commented Mar 8, 2019

BiQuad:

image

PT1:

image

@giacomo892 giacomo892 removed the Feedback required The issue/PR is missing information to proceed further label Mar 8, 2019
@giacomo892 giacomo892 added this to the 2.2 milestone Mar 8, 2019
@giacomo892 giacomo892 merged commit 26f4b01 into iNavFlight:development Mar 8, 2019
@giacomo892 giacomo892 deleted the PT1_gyro_filters_giacomo892 branch March 8, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants