Fix current BB logging and improve battery code #3490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellixyz
force-pushed
the
fix_current_bb_loggin_improve_battery_code
branch
from
af93c55 to
0e676c3
Compare
Member
|
@shellixyz looks like this conflicted with the |
shellixyz
force-pushed
the
fix_current_bb_loggin_improve_battery_code
branch
from
0e676c3 to
784c1b8
Compare
Collaborator
Author
|
Rebased |
fiam
reviewed
Jul 7, 2018
src/main/sensors/battery.c
Outdated
| amperageLatestADC = adcGetChannel(ADC_CURRENT); | ||
| amperageLatestADC = pt1FilterApply4(&erageFilterState, amperageLatestADC, AMPERAGE_LPF_FREQ, timeDelta * 1e-6f); | ||
| amperage = currentSensorToCentiamps(amperageLatestADC); | ||
| case CURRENT_SENSOR_ADC:; |
shellixyz
force-pushed
the
fix_current_bb_loggin_improve_battery_code
branch
from
784c1b8 to
e311f4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current sensor offset was not taken into account in BB log so if
current_sensor_offsetwas different from 0 logged current was always wrong.