Skip to content

Conversation

@fiam
Copy link
Member

@fiam fiam commented Jun 21, 2018

Saves 320 bytes of flash in F3

@fiam fiam added this to the 2.0 milestone Jun 21, 2018
@fiam
Copy link
Member Author

fiam commented Jun 21, 2018

@shellixyz Take a look at this one, please.

@shellixyz
Copy link
Collaborator

shellixyz commented Jun 21, 2018

Unfortunately it won't work correctly. The PID factors for pitch and roll can be adjusted simultaneously (ADJUSTMENT_PITCH_ROLL_P, ADJUSTMENT_PITCH_ROLL_I, ADJUSTMENT_PITCH_ROLL_D). With this mod the PID factors won't blink when pitch and roll are adjusted simultaneously. We could do this: shellixyz@6a7ea1b. Still saves 320 bytes.

I updated the commit I made a mistake.

@fiam
Copy link
Member Author

fiam commented Jun 21, 2018

@shellixyz Thanks! I've cherry-picked your commit and added it to this PR.

@fiam fiam merged commit de87e8c into development Jun 21, 2018
@fiam fiam deleted the agh_use_osd_display_pid_values branch June 21, 2018 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants