Make the OSD home arrow closer to the actual home direction #3387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the first image (up) for [0deg, 22deg] which made some directions like [350deg, 360deg) feel pretty unnatural because the craft was almost pointing home but the arrow pointed a bit to the left. Maximum error between actual direction and the arrow was 22deg. With this change, the up image is used for [349deg, 11deg], 2nd image covers [12deg, 33deg], etc... which makes the error between the actual direction and the arrow smaller. This also cuts the maximum error between the arrow and the actual direction to ~12deg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the first image (up) for [0deg, 22deg] which made
some directions like [350deg, 360deg) feel pretty unnatural because
the craft was almost pointing home but the arrow pointed a bit to
the left. Maximum error between actual direction and the arrow was
22deg.
With this change, the up image is used for [349deg, 11deg], 2nd
image covers [12deg, 33deg], etc... which makes the error between
the actual direction and the arrow smaller. This also cuts the
maximum error between the arrow and the actual direction to ~12deg.