Make FPort stop one sensor cycle every 3 #3308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalentity
approved these changes
Jun 3, 2018
Sending 3 cycles and then pausing once still produces some sensor lost warnings after 10-15 mins, but reducing it to 2 sensors/1 pause seems to get rid of the problem. Since this reduces the effective data rate by 33%, changes have been removed from the SmartPort driver and moved to affect just FPort. This way, S.Port doesn't have suffer any update rate reductions. Fixes #3198 (hopefully for real this time)
When calling it from the fport driver, the payload might be NULL in some cases, causing an invalid dereference. Found by @jirif on betaflight/betaflight#6060
fiam
force-pushed
the
agh_fport_rest_period_2
branch
from
86d4437 to
df5d50d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending 3 cycles and then pausing once still produces some sensor
lost warnings after 10-15 mins, but reducing it to 2 sensors/1 pause
seems to get rid of the problem. Since this reduces the effective data
rate by 33%, changes have been removed from the SmartPort driver and
moved to affect just FPort. This way, S.Port doesn't have suffer any
update rate reductions.
Fixes #3198 (hopefully for real this time)