Make the ROLL/PITCH/YAW PID values blink in the OSD when the corresponding RC adjustment is selected #3252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalentity
requested changes
May 22, 2018
| } | ||
| } | ||
|
|
||
| bool isAdjustmentFunctionSelected(uint8_t adjustmentFunction) { |
Member
There was a problem hiding this comment.
Calling this all the time is quite expensive. processRcAdjustments alredy iterates though all adjustments each RX cycle. A better way would be to keep track of active adjustment functions there and do a fast query to bitmap or array.
Collaborator
Author
There was a problem hiding this comment.
Are you sure it is really necessary to complicate this ? The OSD is only refreshed every 16ms and adjustmentStates is only 4 cells big (4 maximum simultaneous adjustments). I did not profile this function but to me it the time cost should be low.
shellixyz
force-pushed
the
osd_blink_adjusted_values
branch
from
58181d2 to
e17911b
Compare
…nding RC adjustment is selected
shellixyz
force-pushed
the
osd_blink_adjusted_values
branch
from
e17911b to
f54d67f
Compare
digitalentity
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.