Send GPS related sensors via S.Port even without a fix #3207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for feature(FEATURE_GPS) rather than for a GPS fix. This lets users perform the sensor discovery step without having a GPS fix. To still allow users to notice if the GPS has stopped working, we check that either the craft has never been armed or we do have a GPS fix. This way the sensor is available on startup, but if it stops working mid-flight the user will get a "sensor lost" alarm.
Collaborator
|
Good idea. Much better ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for feature(FEATURE_GPS) rather than for a GPS fix. This lets
users perform the sensor discovery step without having a GPS fix.
To still allow users to notice if the GPS has stopped working, we
check that either the craft has never been armed or we do have a GPS
fix. This way the sensor is available on startup, but if it stops
working mid-flight the user will get a "sensor lost" alarm.