Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MATEKF405 target #2566

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Update MATEKF405 target #2566

merged 1 commit into from
Dec 12, 2017

Conversation

digitalentity
Copy link
Member

Changes come from @MATEKSYS.

Copy link
Member Author

@digitalentity digitalentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MATEKSYS, could you please comment on my review?

{ TIM8, IO_TAG(PC8), TIM_Channel_3, 1, IOCFG_AF_PP_PD, GPIO_AF_TIM8, TIM_USE_MC_MOTOR | TIM_USE_FW_SERVO }, //S3 DMA2_ST4 SV4
{ TIM8, IO_TAG(PC9), TIM_Channel_4, 1, IOCFG_AF_PP_PD, GPIO_AF_TIM8, TIM_USE_MC_MOTOR | TIM_USE_FW_SERVO }, //S4 DMA3_ST7 SV5

{ TIM2, IO_TAG(PA15), TIM_Channel_1, 1, IOCFG_AF_PP_PD, GPIO_AF_TIM2, TIM_USE_MC_MOTOR | TIM_USE_LED }, //S5 DMA1_ST5 2812LED
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change PA15 could no longer be used as TIM_USE_FW_SERVO. Is this intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more convenient to use S6(PA8) for FW_servo. S2, S3, S4, S6, 4 servos for Airplane, We tested it today.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, we will release one PDB for fixed wing with S2 S3 S4 S6 arranged

{ TIM1, IO_TAG(PA8), TIM_Channel_1, 1, IOCFG_AF_PP_PD, GPIO_AF_TIM1, TIM_USE_MC_MOTOR | TIM_USE_MC_SERVO | TIM_USE_FW_SERVO }, //S6 DMA2_ST6 SV6
{ TIM4, IO_TAG(PB8), TIM_Channel_3, 1, IOCFG_AF_PP_PD, GPIO_AF_TIM4, TIM_USE_MC_CHNFW | TIM_USE_MC_SERVO | TIM_USE_FW_MOTOR }, //S7 DMA1_ST7 MT2

{ TIM5, IO_TAG(PA2), TIM_Channel_3, 1, IOCFG_AF_PP_PD, GPIO_AF_TIM5, TIM_USE_PWM }, //TX2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? It's allocated as PWM input.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is reserved for future resource command. delete it or not, Up to you. Thanks

Copy link
Contributor

@teckel12 teckel12 Dec 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@digitalentity Would this be used for soft serial? It seems that TX2 used as SS would be useful for FrSky Smartport telemetry so software inversion could be used to avoid the need for hacks or a hardware inverter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it at the moment. We could try using it for softserial in future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@digitalentity @MATEKSYS Looks like a nice FC! May be worth getting one and tweaking in SS support for us FrSky telemetry users. The easily accessible (5) UARTS is super nice! This may be the first board were you don't need to make compromises on what to connect.

@digitalentity digitalentity merged commit 7e280de into development Dec 12, 2017
@digitalentity digitalentity deleted the de_matekf405_update branch December 12, 2017 13:23
@stronnag
Copy link
Collaborator

This is a really unwelcome change for people with existing MR setups with servos.
It breaks existing setups completely.
It moves MR servos off exposed pins onto difficult to solder tiny pads, rendering the board unless
It does not even update the documentation
It gets merged in spite of a "Don't Merge" flag.

@digitalentity
Copy link
Member Author

My fault @stronnag - I didn't test Tri setup, will revert. New MATEK F405-CTR will have to have a different target.

@MATEKSYS
Copy link
Contributor

move TIM_USE_MC_SERVO to S1, keep new FW definitions

@MATEKSYS
Copy link
Contributor

MATEKF405.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants