-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update LedStrip.md #11159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update LedStrip.md #11159
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e672d23
Add GitHub Action to suggest maintenance branches for PRs targeting m…
sensei-hacker 15fc53a
Update .github/workflows/pr-branch-suggestion.yml
sensei-hacker 3e4efe1
Merge pull request #11148 from sensei-hacker/github-action-pr-branch-…
sensei-hacker 82021b5
Github action change pull_request to pull_request_target event
sensei-hacker f28f725
Update LedStrip.md
Barnabasek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| name: PR Branch Suggestion | ||
|
|
||
| on: | ||
| pull_request_target: | ||
| types: [opened] | ||
| branches: | ||
| - master | ||
|
|
||
| jobs: | ||
| suggest-branch: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| pull-requests: write | ||
| steps: | ||
| - name: Suggest maintenance branch | ||
| uses: actions/github-script@v7 | ||
| with: | ||
| script: | | ||
| const comment = `### Branch Targeting Suggestion | ||
|
|
||
| You've targeted the \`master\` branch with this PR. Please consider if a version branch might be more appropriate: | ||
|
|
||
| - **\`maintenance-9.x\`** - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release. | ||
|
|
||
| - **\`maintenance-10.x\`** - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x | ||
|
|
||
| If \`master\` is the correct target for this change, no action is needed. | ||
|
|
||
| --- | ||
| *This is an automated suggestion to help route contributions to the appropriate branch.*`; | ||
|
|
||
| try { | ||
| await github.rest.issues.createComment({ | ||
| issue_number: context.issue.number, | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| body: comment | ||
| }); | ||
| } catch (err) { | ||
| core.setFailed(`Failed to post suggestion comment: ${err}`); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Update the external link to precisely match the referenced timeframe/context (INAV LED Strip) or add a note clarifying it's a Betaflight-specific guide and may differ from INAV. Prefer linking to INAV's own docs if available. [Learned best practice, importance: 6]