-
Notifications
You must be signed in to change notification settings - Fork 1.7k
MSP2 via CSFR telemetry #11093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
MSP2 via CSFR telemetry #11093
Conversation
|
Awesome work. Will SmartPort also get the MSPv2 treatment? |
|
it should work, the changes for MSP2 are in msp_share file, so theoretically i don't see any reasson why it should not work. rob.thomson is going to test it, he has smarport capable gear. |
|
I did have a brief look. There may be some things that need changing in SmartPort regarding the packets. I believe there are examples of this in the BetaFlight or RotorFlight SmartPort.c file. Awesome work though 👍🏻 |
|
do you mean change regarding to skip few request after EEPROM_WRITE command? I will look at that closely :) |
* mspRequestOriginID fix
|
Don’t listen to me, I was misremembering 🤣 The changes in msp_shared should hopefully get it work over SmartPort. |
|
:D, it seems you were right, still some issues with smartport, I'm waiting to rob.thomson for more info. And moreover I will have frsky gear for better smartport testing. However, CRSF works much better, I was able to fetch VERSION frame, PID frame, and save new values for PID frame. there were some insidious bugs :D |
|
Awesome 🤘🏻 Rob mentioned that FrSky are sending you some hardware to get this working. Which is great news. |
|
current status is that CRSF is fully functional. I tested all scenarios from "Testing:" section. Rob.thomson confirmed that CRSF is OK, Smartport is still in progress, Maybe what about to create for smartport new pullrequest? |
PR adds support for MSP2 inspired by implementation from betaflight. PR does not change manupulation with buffers and keep INAV style. In PR is fix for mspRequestOriginID originally made Pawel
<receiver address 8b><sender address 8b><csfr flags 8b><length 8b><cmd 8b><payload ....><receiver address 8b><sender address 8b><csfr flags 8b><MSP flags 8b><cmd 16b LE><length 16b LE><payload ... >example:
Tasks:
Testing:
CRSF (ready for test):
SmartPort:
MSP-test-lua.zip