Skip to content

Conversation

@sensei-hacker
Copy link
Member

This small change seems to solve the issue on DMA / DSHOT not working on one pin on the H743:

#10835

As tested with this target:
#10843

However, I would like to request review by someone who understands the DMA better, probably @shirase or @bkleiner ?

@sensei-hacker sensei-hacker requested a review from bkleiner June 2, 2025 00:40
@sensei-hacker sensei-hacker marked this pull request as ready for review June 2, 2025 04:00
@shirase
Copy link
Contributor

shirase commented Jun 2, 2025

Add USE_DSHOT_DMAR in target. Nothing else. DEF_TIM_DMA__BTCH_TIM4_CH4 - this channel does not exist physically.

@bkleiner
Copy link
Collaborator

bkleiner commented Jun 2, 2025

Add USE_DSHOT_DMAR in target. Nothing else. DEF_TIM_DMA__BTCH_TIM4_CH4 - this channel does not exist physically.

Agreed, using the UP request to substitute is not a good workaround here.

@sensei-hacker
Copy link
Member Author

sensei-hacker commented Jun 2, 2025

Thanks for the responses!

Add USE_DSHOT_DMAR in target. Nothing else.

That's the first thing I tried. Unfortunately that didn't work

When that did not work, I went on the adventure trying to figure out how this stuff works. I found that this change made it "work", but I don't have the background knowledge to know the best/right way to fix it.

@shirase
Copy link
Contributor

shirase commented Jun 3, 2025

dma burst mode use first initialized dma channel for all timer channels. It can not work if first initialized channel is empty. Using DMA_REQUEST_TIM4_UP for dma burst is not break anything. This PR can be merged.

@bkleiner
Copy link
Collaborator

i think this one is good to go?

@sensei-hacker sensei-hacker merged commit 922eaa1 into iNavFlight:master Oct 11, 2025
21 checks passed
@MrD-RC MrD-RC added this to the 9.0 milestone Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants