Skip to content

Conversation

@stronnag
Copy link
Collaborator

After the number of channels was raised to 34 in INAV 8, it seems appropriate to allow a 32bit / 32 channel MSP override mask.

@stronnag stronnag added this to the 9.0 milestone May 26, 2025
@sensei-hacker
Copy link
Member

I'm going through and marking a bunch of PRs as testing needed, then I'm going to encourage some folks to start testing.

@stronnag
Copy link
Collaborator Author

stronnag commented May 26, 2025

Tested successfully with msp_setoverride and mwp HID mode 16bit
Fails in 32 bit ... fix on it's way

@stronnag
Copy link
Collaborator Author

stronnag commented May 26, 2025

Tested OK with 32bit mask:

# override channels 12 & 20
set msp_override_channels = 526336
$ msp_setoverride -d /dev/ttyACM0 --maxchan 34 --every 0 12=1234 20=1234
0.944 Tx: 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567 1234 1567 1567 1567 1567 1567 1567 1567 1234 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567
0.976 Rx: 1492 1495 1500  997  987  987  987  987 1500  987  987 1234 1500 1500 1500 1500  988  988 1500 1234 1500 1500 1500 1500 1500 1500 1500 1500 1500 1500 1500 1500 1500 1500

Both 16bit (ch12) and 32bit(ch20) are overwritten

set msp_override_channels = 0
1.008 Tx: 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567 1234 1567 1567 1567 1567 1567 1567 1567 1234 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567 1567
1.040 Rx: 1492 1495 1500  997  987  987  987  987 1500  987  987  987 1500 1500 1500 1500  988  988 1500 1500 1500 1500 1500 1500 1500 1500 1500 1500 1500 1500 1500 1500 1500 1500

No channels are overwritten.

@b14ckyy
Copy link
Collaborator

b14ckyy commented May 27, 2025

Will run some tests later today as well. But I would say we can add this to a 8.1 release since it does not change existing behavior, even if existing config value is re-used.

@b14ckyy b14ckyy modified the milestones: 9.0, 8.1 May 27, 2025
@stronnag stronnag modified the milestones: 8.1, 9.0 May 27, 2025
@stronnag
Copy link
Collaborator Author

It changes the size of the parameter group, requiring a full erase
Which is why it's queued for 9.0

@stronnag stronnag merged commit c60abea into master Jun 3, 2025
22 checks passed
@stronnag stronnag deleted the jh_extend_msp_override_mask branch June 3, 2025 14:54
sensei-hacker pushed a commit to sensei-hacker/inav_unofficial_targets that referenced this pull request Jul 6, 2025
* extend msp_override_mask to 32bits / channels
* update other override 16bit variables
sensei-hacker pushed a commit to sensei-hacker/inav_unofficial_targets that referenced this pull request Jul 20, 2025
* extend msp_override_mask to 32bits / channels
* update other override 16bit variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants