Reversible motor fixes #10890
Merged
Reversible motor fixes #10890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I have asked one of the users who has this issue to please test this PR. I built a hex for their board. I'm going through and marking a bunch of PRs as testing needed, then I'm going to encourage some folks to start testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #9175 (comment) via the change in
rc_controls.c. Change simply corrects for the fact thatrxConfig()->mincheckisn't applicable for reversible motors and therefore shouldn't be included in the calculation ofrcCommand[THROTTLE].Also includes clean up of other code related to reversible motors and errant
USE_DSHOTdefines,Not yet tested.