-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add more flexibility for minimum ground speed #10720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added overriding min ground speed to the programming framework. - Added reading min ground speed to the programming framework. - Updated nav functions to get the min ground speed via the programming framework. This handles if the override is enabled or not. - Added min ground speed element to the OSD. This involved re-formatting `osdFormatVelocityStr` to take a `osd_speedTypes_e` value. Instead or adding another boolean to define speed types. Moved Airspeed variants in to the function too. **Todo** - [ ] Add getting wind speed to programming framework - [ ] Test
|
If someone could please test this, that would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds flexibility to minimum ground speed configuration by enabling programming framework access for both retrieval and override functionality. The changes allow users to dynamically adjust minimum ground speed (e.g., setting it relative to wind speed) and display it on the OSD.
- Added programming framework support for overriding and reading minimum ground speed
- Enhanced OSD velocity formatting to support different speed types including minimum ground speed
- Added wind speed and direction operands to the programming framework
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/programming/logic_condition.h | Added new operands and override operation for minimum ground speed |
| src/main/programming/logic_condition.c | Implemented minimum ground speed override logic and wind estimation operands |
| src/main/navigation/navigation_fixedwing.c | Updated to use programming framework for minimum ground speed retrieval |
| src/main/io/osd.h | Added new OSD element and speed type enumeration |
| src/main/io/osd.c | Refactored velocity formatting and added minimum ground speed display |
| src/main/drivers/osd_symbols.h | Added minimum ground speed symbol and fixed duplicate ADSB definition |
| src/main/common/maths.h | Added KMH to m/s conversion macro |
| docs/Programming Framework.md | Documented new programming framework features |
| docs/OSD.md | Added minimum ground speed OSD element documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
From the best that I could tell when flying in blustery wind conditions, in order to trigger an event. It appears to be working as it was designed to, when looking back over the OSD footage. |

This PR adds more flexibility to minimum ground speed. Access has been added to the programming framework for retrieval and override. An example use would be setting the min ground speed to be x km/h above the wind speed.
osdFormatVelocityStrto take aosd_speedTypes_evalue. Instead or adding another Boolean to define speed types. Moved Airspeed variants in to the function too. I think it's a neater and more futureproof solution.Requires Configurator iNavFlight/inav-configurator#2382
Todo