Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Filetype detection without extension #77

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Conversation

XenHat
Copy link
Contributor

@XenHat XenHat commented Jun 22, 2023

Related to: #52 #55

I did my best to implement filetype detection using libmagic. This should be available in most distributions.

TODO:

  • Nix package fixes (I cannot test myself. You most likely need file-devel, file-magic, or libmagic to output -lmagic from pkg-config.)

@XenHat XenHat changed the title first draft of filetype detection [RFC] Filetype detection without extension Jun 22, 2023
@vaxerski vaxerski requested a review from fufexan June 22, 2023 11:16
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Maybe in the future we should just ignore the image rather than critting

@vaxerski vaxerski merged commit a1d9ab7 into hyprwm:main Jun 23, 2023
vaxerski pushed a commit that referenced this pull request Jul 17, 2024
* first draft of filetype detection

* Nix: add file dependency

* Fix coding style mistake

* Manually format my code

---------

Co-authored-by: Mihai Fufezan <fufexan@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants