Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows using wallpaper files without extensions #55

Closed
wants to merge 8 commits into from

Conversation

Vlad1-1
Copy link

@Vlad1-1 Vlad1-1 commented Mar 28, 2023

This resolves #52, though it introduces a dependency on the file executable. That shouldn't be a problem though, as on Arch file is required by the base package.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vlad1-1
Copy link
Author

Vlad1-1 commented Mar 29, 2023

Yeah, that would be way cleaner, although the function wouldn't be used anywhere else in hyprpaper.
I will try to do something like that

@vaxerski
Copy link
Member

Yeah, that would be way cleaner, although the function wouldn't be used anywhere else in hyprpaper.

at the moment, in the future, who knows.

@Vlad1-1
Copy link
Author

Vlad1-1 commented Mar 29, 2023

I didn't completely copy the code from hyprland at all

src/render/WallpaperTarget.cpp Outdated Show resolved Hide resolved
@Vlad1-1
Copy link
Author

Vlad1-1 commented Mar 30, 2023

That if was meant to check if for some reason the file binary, the program that actually checks the file type doesn't exist, but I forgot execAndGet logs that already

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Vlad1-1
Copy link
Author

Vlad1-1 commented Apr 4, 2023

Just a note, as the initial comment is kind of hidden now, you might want to add file (the binary) to the dependency list on AUR when you merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is hyprpaper.conf sensitive to the file extension?
2 participants