-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows using wallpaper files without extensions #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ew. Why not use something like
https://github.com/hyprwm/Hyprland/blob/d6241a3086c4abfd21e91e23c83c97c3f80123d4/src/helpers/MiscFunctions.cpp#L389-L401
Yeah, that would be way cleaner, although the function wouldn't be used anywhere else in hyprpaper. |
at the moment, in the future, who knows. |
I didn't completely copy the code from hyprland at all |
That if was meant to check if for some reason the file binary, the program that actually checks the file type doesn't exist, but I forgot execAndGet logs that already |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Just a note, as the initial comment is kind of hidden now, you might want to add file (the binary) to the dependency list on AUR when you merge this |
This resolves #52, though it introduces a dependency on the file executable. That shouldn't be a problem though, as on Arch file is required by the base package.