Skip to content

Conversation

@SupernaviX
Copy link
Contributor

Proposed changes

Bump the postgresql16-client version used in the dockerfile, to one which doesn't conflict with the base image.


Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • My Pull Request title is in format < issue name > eg Added links in the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)


Other Information

It might be a good idea to "pin" the manifest's base image:

firefly/manifest.json

Lines 53 to 55 in d87917d

"base": {
"image": "alpine:3.19"
}
to alpine:3.19.7. It's not pinned to a specific patch right now, and this is the second time a patch update has broken the pinned dependency versions in the dockerfile.

Signed-off-by: Simon Gellis <simongellis@gmail.com>
@SupernaviX SupernaviX requested a review from a team as a code owner February 24, 2025 17:50
@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (611834d) to head (0cf7901).
Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1643   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         337      337           
  Lines       29504    29504           
=======================================
  Hits        29492    29492           
  Misses          8        8           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EnriqueL8
Copy link
Contributor

We just fixed this one as part of #1640 but @SupernaviX would appreciate a PR to pin the version of the base image

@SupernaviX SupernaviX closed this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants