Rename metrics to monitoring to support additional routes #1640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chengxuan
force-pushed
the
monitoring-routes
branch
2 times, most recently
from
f079a84 to
919495d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1640 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 337 337
Lines 29504 29524 +20
=======================================
+ Hits 29492 29512 +20
Misses 8 8
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Chengxuan
force-pushed
the
monitoring-routes
branch
from
bf6ad5a to
6ada040
Compare
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
…o monitoring-routes
EnriqueL8
reviewed
Feb 21, 2025
Chengxuan
force-pushed
the
monitoring-routes
branch
from
9998013 to
d2e0652
Compare
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Chengxuan
force-pushed
the
monitoring-routes
branch
from
d2e0652 to
eb60b6c
Compare
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
EnriqueL8
approved these changes
Feb 24, 2025
Contributor
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
Looks good @Chengxuan - We will need to add this to the release notes for folks to be aware of
Comment on lines
+484
to
+500
| go func() { | ||
| if err := server.ListenAndServeTLS(publicKeyFile.Name(), privateKeyFile.Name()); err != nil && err != http.ErrServerClosed { | ||
| log.Fatalf("ListenAndServeTLS(): %v", err) | ||
| } | ||
| }() | ||
|
|
||
| // Wait for the server to be ready | ||
| for { | ||
| conn, err := tls.Dial("tcp", server.Addr, &tls.Config{ | ||
| InsecureSkipVerify: true, | ||
| }) | ||
| if err == nil { | ||
| conn.Close() | ||
| break | ||
| } | ||
| time.Sleep(10 * time.Millisecond) | ||
| } |
EnriqueL8
changed the title
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As elaborated in hyperledger/firefly-common#167, there is a need to expose more endpoints for operational checks.
This PR propose a new
monitoringsections in the configuration file for configurations of the monitoring server:metricsPathThe new monitoring server itself is a replacement for the existing metrics server.
As a result the existing
metricssection is marked as deprecated.Adding monitoring routes for the latest best practices. The existing
metricsconfig is marked as deprecated.The FireFly API path has been split into
apiandspiand then namespacedapi. So adopting the common utils will need some dedicated time, which I didn't manage to do.Types of changes
Please make sure to follow these points
< issue name >egAdded links in the documentation.Screenshots (If Applicable)
Other Information
Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.