Refactor maybePersistBlockchainEvent to Return a Boolean Indicating Event Creation Status
#1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnriqueL8
reviewed
Aug 15, 2024
Contributor
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
Looks good - a few comments
…f the event was created Signed-off-by: dwertent <david.wertenteil@kaleido.io>
Co-authored-by: Enrique Lacal <enriquelacal@gmail.com> Signed-off-by: David Wertenteil <david.wertenteil@kaleido.io> Signed-off-by: dwertent <david.wertenteil@kaleido.io>
Signed-off-by: dwertent <david.wertenteil@kaleido.io>
dwertent
force-pushed
the
fix-duplicate-metrics-call
branch
from
3ea58f8 to
55cf059
Compare
Contributor
|
@dwertent just build failing because of the copyright date, we can probably write a small command to update the ones modified |
Signed-off-by: dwertent <david.wertenteil@kaleido.io>
EnriqueL8
reviewed
Aug 16, 2024
Contributor
|
Re-ran the build to upload the code coverage as the repo was deactivated in CodeCov for some reason... |
Contributor
|
@dwertent more copyright failures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 325 325
Lines 24049 24055 +6
=========================================
+ Hits 24049 24055 +6 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@EnriqueL8 I think we said we would merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the
maybePersistBlockchainEvent()function to return a boolean indicating whether a blockchain event was newly created. This change prevents the double-counting of metrics by ensuring thatemitBlockchainEventMetric()is only called for new events.Fixes #1294.