Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential bug in Env default value provider #644

Merged
merged 9 commits into from
Apr 7, 2020
Merged

Fix potential bug in Env default value provider #644

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
06bc01d
Fix potential bug in Env default value provider
usmansaleem Apr 3, 2020
4285157
Adding unit test case
usmansaleem Apr 3, 2020
c05598b
errorprone suggestion
usmansaleem Apr 3, 2020
5e86996
spotless fix
usmansaleem Apr 3, 2020
dc5ee81
Use isPositional
usmansaleem Apr 3, 2020
db0a37b
Merge branch 'master' into env_provider_bug
usmansaleem Apr 3, 2020
2f63992
Merge branch 'master' into env_provider_bug
usmansaleem Apr 4, 2020
f3c1771
Merge branch 'master' into env_provider_bug
usmansaleem Apr 7, 2020
2d9133b
Merge branch 'master' into env_provider_bug
usmansaleem Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding unit test case 
Signed-off-by: Usman Saleem <usman@usmans.info>
  • Loading branch information
@usmansaleem
usmansaleem committed Apr 3, 2020
commit 4285157f30eadfc565becc01dc095585afc94d41
9 changes: 9 additions & 0 deletions besu/src/test/java/org/hyperledger/besu/cli/EnvironmentVariableDefaultProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

import org.junit.Test;
import picocli.CommandLine.Model.OptionSpec;
import picocli.CommandLine.Model.PositionalParamSpec;
import picocli.CommandLine.Model.PositionalParamSpec.Builder;

public class EnvironmentVariableDefaultProviderTest {

Expand Down Expand Up @@ -76,4 +78,11 @@ public void shouldPreferBesuPrefixOverLegacyPrefix() {
assertThat(provider.defaultValue(OptionSpec.builder("--env-var", "--env-var-set").build()))
.isEqualTo("abc");
}

@Test
public void shouldReturnNullForPositionalParameter() {
environment.put("BESU_KEY", "abc");
final Builder positional = PositionalParamSpec.builder().descriptionKey("key");
assertThat(provider.defaultValue(positional.build())).isNull();
}
}