Fix potential bug in Env default value provider #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Bypass default value for positional parameter. In case of subcommands such as help this could have thrown class cast exception Signed-off-by: Usman Saleem <usman@usmans.info>
CjHare
reviewed
Apr 3, 2020
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
CjHare
reviewed
Apr 3, 2020
| @@ -36,6 +36,10 @@ public EnvironmentVariableDefaultProvider(final Map<String, String> environment) | |||
|
|
|||
| @Override | |||
| public String defaultValue(final ArgSpec argSpec) { | |||
| if (!argSpec.isOption()) { | |||
There was a problem hiding this comment.
What is the reasoning for using the negation of isOption() instead of simply using isPositional() to identify a positional param?
There was a problem hiding this comment.
fair point ... I think I saw an example which was using isOption which stuck in my head, i didn't realised about isPositional. I'll change it to use isPositional. 👍
Signed-off-by: Usman Saleem <usman@usmans.info>
CjHare
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bypass default value from environment variable provider for positional parameter. In case of subcommands such as help this could have thrown class cast exception
Signed-off-by: Usman Saleem usman@usmans.info