Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .idea directory in spotless checks #4657

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Ignore .idea directory in spotless checks #4657

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4160915
ignore .idea directory in spotless checks
daniellehrner Nov 11, 2022
d10b793
Rather than one-by-one exclusions we should have a more focused inclu…
daniellehrner Nov 14, 2022
186e55f
Merge branch 'main' into spotless_ignore_.idea
daniellehrner Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ allprojects {
java {
// This path needs to be relative to each project
target '**/*.java'
targetExclude '**/src/reference-test/**', '**/src/main/generated/**', '**/src/test/generated/**', '**/src/jmh/generated/**'
targetExclude '**/src/reference-test/**', '**/src/main/generated/**', '**/src/test/generated/**', '**/src/jmh/generated/**', '.idea/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than one-by-one exclusions we should have a more focused inclusion.

Suggested change
target '**/*.java'
targetExclude '**/src/reference-test/**', '**/src/main/generated/**', '**/src/test/generated/**', '**/src/jmh/generated/**'
targetExclude '**/src/reference-test/**', '**/src/main/generated/**', '**/src/test/generated/**', '**/src/jmh/generated/**', '.idea/**'
target 'src/**/*.java'
targetExclude 'src/reference-test/**', 'src/main/generated/**', 'src/test/generated/**', 'src/jmh/generated/**'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. That is much better. I've changed it.

removeUnusedImports()
googleJavaFormat('1.10.0')
importOrder 'org.hyperledger', 'java', ''
Expand Down