Ignore .idea directory in spotless checks

[daniellehrner]

Signed-off-by: Daniel Lehrner daniel.lehrner@consensys.net

PR description

InteliJ allows to define templates for different files like Java classes, interfaces,... If those templates are saved in the project they are saved as .java files in a subdirectory of .idea.

Such a template looks for example like this:

#parse("Copyright Besu.java")
#if (${PACKAGE_NAME} && ${PACKAGE_NAME} != "")package ${PACKAGE_NAME};#end
public class ${NAME} {
}

Spotless currently tries to check this templates, because it is configured to analyze all Java files. This check will fail, because the templates are not valid Java code.

This PR excludes all the files in the .idea directory from the spotless check to avoid those false positives.

Documentation

• I thought about documentation and added the doc-change-required label to this PR if
  updates are required.

Changelog

• I thought about the changelog and included a changelog update if required.

[shemnon]

Rather than one-by-one exclusions we should have a more focused inclusion.

Suggested change

	target '**/*.java'
	targetExclude '**/src/reference-test/**', '**/src/main/generated/**', '**/src/test/generated/**', '**/src/jmh/generated/**'
	targetExclude '**/src/reference-test/**', '**/src/main/generated/**', '**/src/test/generated/**', '**/src/jmh/generated/**', '.idea/**'
	target 'src/**/*.java'
	targetExclude 'src/reference-test/**', 'src/main/generated/**', 'src/test/generated/**', 'src/jmh/generated/**'

[daniellehrner]

You are right. That is much better. I've changed it.