Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapsync logging for clearer sync status. Issue 4346. #4347

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Update snapsync logging for clearer sync status. Issue 4346. #4347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...src/main/java/org/hyperledger/besu/ethereum/eth/sync/snapsync/SnapsyncMetricsManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ private void print(final boolean isHeal) {
public void notifySnapSyncCompleted() {
final Duration duration = Duration.ofMillis(System.currentTimeMillis() - startSyncTime);
LOG.info(
"Finished snapsync with nodes {} (healed={}) duration {}{}:{},{}",
"Finished worldstate snapsync with nodes {} (healed={}) duration {}{}:{},{}. Sync block import still in progress...",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text "Sync block import still in progress..." may not be the most suitable here, because the healing step can finish after blocks import.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on this - fixing in #4351

nbNodesGenerated.addAndGet(nbNodesHealed.get()),
nbNodesHealed,
duration.toHoursPart() > 0 ? (duration.toHoursPart() + ":") : "",
Expand Down