Update snapsync logging for clearer sync status. Issue 4346. #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Nelson <matt.nelson@consensys.net>
ahamlat
reviewed
Sep 6, 2022
| @@ -156,7 +156,7 @@ private void print(final boolean isHeal) { | |||
| public void notifySnapSyncCompleted() { | |||
| final Duration duration = Duration.ofMillis(System.currentTimeMillis() - startSyncTime); | |||
| LOG.info( | |||
| "Finished snapsync with nodes {} (healed={}) duration {}{}:{},{}", | |||
| "Finished worldstate snapsync with nodes {} (healed={}) duration {}{}:{},{}. Sync block import still in progress...", | |||
There was a problem hiding this comment.
The text "Sync block import still in progress..." may not be the most suitable here, because the healing step can finish after blocks import.
There was a problem hiding this comment.
Agreed on this - fixing in #4351
2 tasks
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
…4347) Signed-off-by: Matt Nelson <matt.nelson@consensys.net> Signed-off-by: Matt Nelson <matt.nelson@consensys.net>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
…4347) Signed-off-by: Matt Nelson <matt.nelson@consensys.net> Signed-off-by: Matt Nelson <matt.nelson@consensys.net>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
…4347) Signed-off-by: Matt Nelson <matt.nelson@consensys.net> Signed-off-by: Matt Nelson <matt.nelson@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…4347) Signed-off-by: Matt Nelson <matt.nelson@consensys.net> Signed-off-by: Matt Nelson <matt.nelson@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Nelson matt.nelson@consensys.net
PR description
Fixed Issue(s)
Fixes #4346.
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog