Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print warning for deprecated testnets #4173

Merged
merged 9 commits into from
Jul 28, 2022
Merged

Print warning for deprecated testnets #4173

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4119199
print warning for deprecated testnets
daniellehrner Jul 26, 2022
6af6a24
added CHANGELOG.md entry
daniellehrner Jul 26, 2022
8fc3a8c
refactored to use logger of BesuCommand, added tests
daniellehrner Jul 27, 2022
a54aa8e
Merge branch 'main' of github.com:hyperledger/besu into main
daniellehrner Jul 27, 2022
9b225bb
Merge branch 'main' into warn_deprecated_networks
daniellehrner Jul 27, 2022
2d037eb
fixed spotless errors
daniellehrner Jul 27, 2022
4e89abb
made test more readable, simplified method for human readable network…
daniellehrner Jul 27, 2022
6560d66
Merge branch 'main' into warn_deprecated_networks
daniellehrner Jul 27, 2022
8c4182f
Merge branch 'main' into warn_deprecated_networks
daniellehrner Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed spotless errors 
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
  • Loading branch information
@daniellehrner
daniellehrner committed Jul 27, 2022
commit 2d037eb935147b9c5b596db7726bfe9b2b0e4ed9
3 changes: 2 additions & 1 deletion besu/src/test/java/org/hyperledger/besu/cli/NetworkDeprecationMessageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ void shouldGenerateDeprecationMessageForDeprecatedNetworks(final NetworkName net
names = {"RINKEBY", "ROPSTEN", "KILN"},
daniellehrner marked this conversation as resolved.
Show resolved Hide resolved
mode = EnumSource.Mode.EXCLUDE)
void shouldThrowErrorForNonDeprecatedNetworks(final NetworkName network) {
assertThatThrownBy(() -> NetworkDeprecationMessage.generate(network)).isInstanceOf(AssertionError.class);
assertThatThrownBy(() -> NetworkDeprecationMessage.generate(network))
.isInstanceOf(AssertionError.class);
}
}