Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print warning for deprecated testnets #4173

Merged
merged 9 commits into from
Jul 28, 2022
Merged

Print warning for deprecated testnets #4173

merged 9 commits into from
Jul 28, 2022

Conversation

daniellehrner
Copy link
Contributor

Signed-off-by: Daniel Lehrner daniel.lehrner@consensys.net

PR description

Prints a deprecation warning for Ropsten, Kiln and Rinkeby

Fixed Issue(s)

fixes #4163

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

The documentation should mention that Ropsten, Rinkeby and Kiln are deprecated

Changelog

@daniellehrner
print warning for deprecated testnets
4119199 
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner daniellehrner added the doc-change-required Indicates an issue or PR that requires doc to be updated label Jul 26, 2022
@daniellehrner
added CHANGELOG.md entry
6af6a24 
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner
refactored to use logger of BesuCommand, added tests
8fc3a8c 
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner
Merge branch 'main' of github.com:hyperledger/besu into main
a54aa8e
@daniellehrner
Merge branch 'main' into warn_deprecated_networks
9b225bb
@daniellehrner
fixed spotless errors
2d037eb 
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner daniellehrner marked this pull request as ready for review July 27, 2022 11:05
jflo
jflo requested changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2nd test on throwing error for non-deprecated networks is only run against deprecated networks. I think the input enums should be switched to MAINNET, SEPOLIA, GOERLI

besu/src/test/java/org/hyperledger/besu/cli/NetworkDeprecationMessageTest.java Outdated Show resolved Hide resolved
@daniellehrner
made test more readable, simplified method for human readable network…
4e89abb 
… name

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner daniellehrner requested a review from jflo July 27, 2022 17:04
jflo
jflo approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@daniellehrner daniellehrner enabled auto-merge (squash) July 28, 2022 21:20
@daniellehrner daniellehrner merged commit 3913174 into hyperledger:main Jul 28, 2022
@alexandratran alexandratran mentioned this pull request Aug 11, 2022
Closed
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Aug 11, 2022
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@daniellehrner @eum602
Print warning for deprecated testnets (hyperledger#4173)
82fd91f 
* print warning for deprecated testnets

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jflo jflo jflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add deprecation warning for Ropsten, Kiln, Rinkeby
3 participants
@daniellehrner @jflo @alexandratran