Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BftForkSpec to ForkSpec and make it generic #3087

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Rename BftForkSpec to ForkSpec and make it generic #3087

merged 3 commits into from
Nov 19, 2021

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Nov 19, 2021 •
edited
Loading

PR description

This was split out of #3069. Changes the BftForkSpec to more generic concept so it can be reused in the QBFT migration.

  • Rename BftForkSpec to ForkSpec
  • Move from consenus.common.bft package in the consensus.common package
  • Allow it to hold any value not just a BftConfigOption
  • Rename getConfigOption to getValue

Fixed Issue(s)

Changelog

@jframe
Rename BftForkSpec to ForkSpec and make it generic
517ab44 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
rename var
7b120ab 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe jframe added the TeamGroot GH issues worked on by Groot Team label Nov 19, 2021
@jframe
fix some usages that didn't get updated
4c02299 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
usmansaleem
usmansaleem approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jframe jframe enabled auto-merge (squash) November 19, 2021 05:16
siladu
siladu approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.2% 88.2% Coverage
0.0% 0.0% Duplication

@jframe jframe merged commit b1e2496 into hyperledger:main Nov 19, 2021
@jframe jframe deleted the rename_bft_fork_spec branch November 19, 2021 05:56
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@jframe @eum602
Rename BftForkSpec to ForkSpec and make it generic (hyperledger#3087)
f9112cc 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

@usmansaleem usmansaleem usmansaleem approved these changes

@lucassaldanha lucassaldanha Awaiting requested review from lucassaldanha

Assignees
No one assigned
Labels
TeamGroot GH issues worked on by Groot Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jframe @usmansaleem @siladu