Qbft migration protocol schedule #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
… capabilities. Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
usmansaleem
reviewed
Nov 16, 2021
besu/src/main/java/org/hyperledger/besu/controller/ConsensusScheduleBesuControllerBuilder.java
Outdated
Show resolved
Hide resolved
siladu
reviewed
Nov 16, 2021
...rc/test/java/org/hyperledger/besu/controller/ConsensusScheduleBesuControllerBuilderTest.java
Outdated
Show resolved
Hide resolved
besu/src/main/java/org/hyperledger/besu/controller/ConsensusScheduleBesuControllerBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
siladu
reviewed
Nov 17, 2021
besu/src/main/java/org/hyperledger/besu/controller/ConsensusScheduleBesuControllerBuilder.java
Outdated
Show resolved
Hide resolved
siladu
reviewed
Nov 18, 2021
besu/src/main/java/org/hyperledger/besu/controller/ConsensusScheduleBesuControllerBuilder.java
Outdated
Show resolved
Hide resolved
lucassaldanha
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
LGTM. One suggestion would be to move the logic inside createProtocolSchedule() into a separate class (CombinedProtocolSchedule or something else). This can make it easier to test and also make the code in ConsensusScheduleBesuControllerBuilder easier to understand.
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
…lls combined protocol schedule factory Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
1 task
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
lucassaldanha
approved these changes
Nov 22, 2021
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
…besu into qbft_migration_protocol_schedule
|
Kudos, SonarCloud Quality Gate passed! |
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Create a combined protocol schedule for the QBFT migration that combines all the milestones from the delegate besu controllers protocol schedules.
fixes #2998
Fixed Issue(s)
Changelog