Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discovery packet size #2252

Merged
merged 5 commits into from
May 11, 2021
Merged

Fix discovery packet size #2252

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
916297e
Fix discovery packet size
atoulme May 8, 2021
13d2045
Add assertion to check the size of the packet once encoded
atoulme May 9, 2021
22b668c
Merge branch 'master' into fix_discovery_packets
macfarla May 11, 2021
fb25509
code review
atoulme May 11, 2021
597074d
Merge branch 'master' into fix_discovery_packets
macfarla May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code review 
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
  • Loading branch information
@atoulme
atoulme committed May 11, 2021
commit fb2550925b4cb89f8e4103e14302031b729034e5
4 changes: 2 additions & 2 deletions ...p2p/src/test/java/org/hyperledger/besu/ethereum/p2p/discovery/PeerDiscoveryAgentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@ public void neighborsPacketLimited() {
assertThat(neighbors.getNodes()).hasSize(13);
assertThat(neighborsPacket.packet.encode().length()).isLessThanOrEqualTo(1280); // under max MTU

// Assert that after removing those 13 items we're left with either 4 or 5.
// If we are left with 5, the test peer was returned as an item, assert that this is the case.
// Assert that after removing those 13 items we're left with either 7 or 8.
// If we are left with 8, the test peer was returned as an item, assert that this is the case.
otherPeers.removeAll(neighbors.getNodes());
assertThat(otherPeers.size()).isBetween(7, 8);
if (otherPeers.size() == 8) {
Expand Down