Fix discovery packet size #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
reviewed
May 8, 2021
...um/p2p/src/test/java/org/hyperledger/besu/ethereum/p2p/discovery/PeerDiscoveryAgentTest.java
Show resolved
Hide resolved
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
atoulme
force-pushed
the
fix_discovery_packets
branch
from
30db95f to
13d2045
Compare
shemnon
approved these changes
May 11, 2021
shemnon
reviewed
May 11, 2021
...um/p2p/src/test/java/org/hyperledger/besu/ethereum/p2p/discovery/PeerDiscoveryAgentTest.java
Outdated
Show resolved
Hide resolved
shemnon
reviewed
May 11, 2021
...um/p2p/src/test/java/org/hyperledger/besu/ethereum/p2p/discovery/PeerDiscoveryAgentTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Fix discovery packet size Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * Add assertion to check the size of the packet once encoded Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * code review Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antoine Toulme antoine@lunar-ocean.com
PR description
Make sure Besu sends NEIGHBORS packets under MTU size.
Fixed Issue(s)
#2250
Changelog