Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coded elliptic curve lengths #1967

Closed
wants to merge 6 commits into from
Closed

Remove hard coded elliptic curve lengths #1967

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43deaf5
Removed hardcoded key lengths and added test with different key lengt…
daniel-iobuilders Feb 26, 2021
00e8706
added missing javadoc parameter
daniel-iobuilders Mar 2, 2021
458d49e
Added missing spaces to string. Remove fixed byte size in comment
daniel-iobuilders Mar 5, 2021
11f551d
Removed fixed byte size from Packet class
daniel-iobuilders Mar 5, 2021
f6a00c1
Replaced Bytes32 in SignatureAlgorithm with Bytes
daniel-iobuilders Mar 9, 2021
4a9ef40
WIP: Added SECP384R1 crypto algorithm
daniel-iobuilders Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added missing javadoc parameter 
Signed-off-by: Daniel Lehrner <daniel@io.builders>
  • Loading branch information
@daniel-iobuilders
daniel-iobuilders committed Mar 2, 2021
commit 00e870650dd9b57d952c30163aef1a1a897e897f
1 change: 1 addition & 0 deletions crypto/src/main/java/org/hyperledger/besu/crypto/SECPSignature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ public class SECPSignature {
* @param s the 's' part of the signature.
* @param recId the recovery id part of the signature.
* @param curveOrder The order (n) of the used curve
* @param privateKeyLength The length of the key in byte
* @return the created {@link SECPSignature} object.
* @throws NullPointerException if {@code r} or {@code s} are {@code null}.
* @throws IllegalArgumentException if any argument is invalid (for instance, {@code v} is neither
Expand Down