Remove hard coded elliptic curve lengths #1967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hs and elliptic curves. Signed-off-by: Daniel Lehrner <daniel@io.builders>
Signed-off-by: Daniel Lehrner <daniel@io.builders>
daniel-iobuilders
changed the title
| @@ -69,7 +69,9 @@ private static Bytes serializeHeaderWithoutProposerSeal( | |||
| private static Bytes encodeExtraDataWithoutProposerSeal(final CliqueExtraData cliqueExtraData) { | |||
| final Bytes extraDataBytes = cliqueExtraData.encode(); | |||
| // Always trim off final 65 bytes (which maybe zeros) | |||
There was a problem hiding this comment.
The comment needs to be changed to reflect it might not be 65 anymore :)
| final byte recId = bytes.get(64); | ||
| return SECPSignature.create(r, s, recId, curveOrder); | ||
| bytes.size() == signatureLength, | ||
| new StringBuilder() |
There was a problem hiding this comment.
We are missing the spaces between the appends, aren't we?
Signed-off-by: Daniel Lehrner <daniel@io.builders>
Signed-off-by: Daniel Lehrner <daniel@io.builders>
Signed-off-by: Daniel Lehrner <daniel@io.builders>
Signed-off-by: Daniel Lehrner <daniel@io.builders>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Lehrner daniel@io.builders
As discussed in #1933, the byte size for different variables of the elliptic curve cryptography are hard coded and don't allow the future implementation of algorithms other than SECP256*. This PR removes all these hard coded byte sizes and replaces them by dynamic ones. This allows the future implementation of algorithms like SECP384R1 (NIST P-384).
This is a simple refactoring, no existing functionality was modified or removed, neither was a new one added.