Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire qbft message validation into business logic #1813

Merged
merged 23 commits into from
Jan 20, 2021
Merged

Wire qbft message validation into business logic #1813

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
687bf1b
Qbft Proposal Validation created
Jan 13, 2021
f45fcf8
changed how we find best roundchange
Jan 14, 2021
4f24ae1
trying to clean up proposal validation tests
Jan 15, 2021
85ce918
adding more testS
Jan 15, 2021
f0bf2f0
added more tests
Jan 17, 2021
98e2762
think we have it solvd
Jan 17, 2021
605cc55
Merge remote-tracking branch 'upstream/master' into qbft_prop_val
Jan 17, 2021
46d1980
fixed test issues
Jan 17, 2021
dae32f4
re-enabled tests
Jan 18, 2021
fb959f5
fix spotless
Jan 18, 2021
83342b2
added more tests
Jan 18, 2021
557e5c8
Merge remote-tracking branch 'upstream/master' into val_wiring
Jan 18, 2021
c9599a5
more spotless fix
Jan 18, 2021
84ae35d
Merge remote-tracking branch 'upstream/master' into val_wiring
Jan 19, 2021
eef7be4
remove unused file
Jan 19, 2021
05c5f3c
fixed int tests
Jan 19, 2021
cd478ee
tryig to clean up a little
Jan 19, 2021
c2bc3f6
fix spotless
Jan 19, 2021
dcdbf6c
Merge branch 'master' into val_wiring
rain-on Jan 20, 2021
aee8be3
Merge remote-tracking branch 'upstream/master' into val_wiring
Jan 20, 2021
e9d6c4f
Merge remote-tracking branch 'origin/val_wiring' into val_wiring
Jan 20, 2021
cca7f34
Merge remote-tracking branch 'upstream/master' into val_wiring
Jan 20, 2021
e23b511
post review
Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed test issues 
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
  • Loading branch information
Trent Mohay committed Jan 17, 2021
commit 46d198034aea8e93b2d3777948f4bd6939c395d3
8 changes: 4 additions & 4 deletions ...t/src/test/java/org/hyperledger/besu/consensus/qbft/validation/ProposalValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ private enum ROUND_ID {
ONE
}

private class RoundSpecificItems {
private static class RoundSpecificItems {

public final Block block;
public final ConsensusRoundIdentifier roundIdentifier;
Expand All @@ -87,7 +87,7 @@ public RoundSpecificItems(
@Mock private WorldStateArchive worldStateArchive;
private ProtocolContext protocolContext;

private Map<ROUND_ID, RoundSpecificItems> roundItems = new HashMap<>();
private final Map<ROUND_ID, RoundSpecificItems> roundItems = new HashMap<>();

@Before
public void setup() {
Expand Down Expand Up @@ -126,8 +126,8 @@ private RoundSpecificItems createRoundSpecificItems(final int roundNumber) {

private Proposal createProposal(
final RoundSpecificItems roundItem,
List<SignedData<RoundChangePayload>> roundChanges,
List<SignedData<PreparePayload>> prepares) {
final List<SignedData<RoundChangePayload>> roundChanges,
final List<SignedData<PreparePayload>> prepares) {
return validators
.getMessageFactory(0)
.createProposal(roundItem.roundIdentifier, roundItem.block, roundChanges, prepares);
Expand Down