Wire qbft message validation into business logic #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 15, 2021 08:34
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
added 6 commits
January 19, 2021 09:17
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
jframe
reviewed
Jan 20, 2021
...bft/src/integration-test/java/org/hyperledger/besu/consensus/qbft/test/FutureHeightTest.java
Show resolved
Hide resolved
...java/org/hyperledger/besu/consensus/qbft/validation/FutureRoundProposalMessageValidator.java
Outdated
Show resolved
Hide resolved
...nsus/qbft/src/main/java/org/hyperledger/besu/consensus/qbft/validation/MessageValidator.java
Outdated
Show resolved
Hide resolved
...nsus/qbft/src/main/java/org/hyperledger/besu/consensus/qbft/validation/MessageValidator.java
Outdated
Show resolved
Hide resolved
...nsus/qbft/src/main/java/org/hyperledger/besu/consensus/qbft/validation/MessageValidator.java
Outdated
Show resolved
Hide resolved
...nsus/qbft/src/main/java/org/hyperledger/besu/consensus/qbft/validation/MessageValidator.java
Outdated
Show resolved
Hide resolved
added 2 commits
January 20, 2021 12:34
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
jframe
approved these changes
Jan 20, 2021
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
All received QBFT messages are now validated with respect to protocol safety prior to be accepted to QBFT business logic. This includes updates to the QBFT integration test framework. Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Wires the message validating logic into the business logic of QBFT
Fixed Issue(s)
N/A
Changelog
N/A